Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with Twisted system #8

Open
pythonmobile opened this issue Dec 21, 2012 · 6 comments
Open

Testing with Twisted system #8

pythonmobile opened this issue Dec 21, 2012 · 6 comments

Comments

@pythonmobile
Copy link

It would be nice if this codebase was automatically tested by the Twisted buildbot. Has this been talked about? With the release of 12.3.0, its high time perhaps?

@ghtdak
Copy link
Owner

ghtdak commented Dec 22, 2012

I've been in touch with the Twisted folks a couplea times.

The Qt Reactor was not included with the Twisted code because of licensing issues with PyQt. Now that it works with PySide (I'm told), it could be brought into Twisted itself.

IIRC, even the PyQt licensing might not be an issue any longer although that would need to be verified.

So, if someone wanted to do the work and get it into Twisted, I think everything becomes easier.

@michaelnt
Copy link
Contributor

The Twisted team are happy to include the code but they first need a way to
test it. In my last job I set up a buildslave with python, pyside and a
qt4reactor but I think this has stopped working since I left. It is
probably relatively easy to get a pyside/linux build slave running, now
that it's included in some distributions.

The other (bigger) problem is getting the entire twisted test suite to pass
when using this reactor, there aren't many tests for the reactor and it is
tested (at least partly) by having it run the entire test suite.

Michael

On 21 December 2012 21:00, pythonmobile notifications@github.com wrote:

It would be nice if this codebase was automatically tested by the Twisted
buildbot. Has this been talked about? With the release of 12.3.0, its high
time perhaps?


Reply to this email directly or view it on GitHubhttps://github.com//issues/8.

@ghtdak
Copy link
Owner

ghtdak commented Jun 11, 2013

Way back when I originally wrote the Qt Reactor, Twisted Trial would run through, mostly without incident. The failures, IIRC, weren't concerning to the Twisted folks.

I haven't tried Trial lately... not with PySide or Qt5 (There's another thread on this topic).

@marcusmoller
Copy link

So any news? Would love to integrate PySide into my Twisted application - how would I be doing that these days?

@ghtdak
Copy link
Owner

ghtdak commented Sep 18, 2014

PySide is included. I'm not closing this thread because I really want somebody to hammer on the implementation with the twisted suite of testing tools. My environment has gotten a bit behind.

@ghtdak
Copy link
Owner

ghtdak commented Sep 24, 2014

So, the full blown run of trial

trial --reactor=[qt4 | pyqt4 | pyside] twisted

takes about a minute on a server class machine. The problem with the Twisted buildbot is that they'd need to maintain Qt.

However, I used to have a server supporting twisted... and I could probably do that again. I'll look into it. I'll leave this thread open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants