Use WebGL ChemDoodle viewer if supported #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTML template is a bit unwieldy with large portions of embedded javascript and CSS, so this moves them into their own files and then embeds them in the same way as ChemDoodle and the template variables.
Pass PDB and CIF files straight to ChemDoodle. For all other files, use Open Babel if available to convert to ChemDoodle JSON and pass that to ChemDoodle.
The function now returns a copy of the molecule so we can have differently scaled molecules for each viewer canvas.
Render slightly larger, increase buffer between bonds and element labels, and allow zooming and rotation.
This allows for better 3D rendering in general, and unit cell display with CIFs.
If the user has other chemistry apps installed, they can re-assign the UTI of files to something else. By adding those UTIs to `LSItemContentTypes` we register ChemLook as still being able to preview them.
|
I'm actually going to switch from ChemDoodle for WebGL to a different package (http://3dmol.csb.pitt.edu) but I appreciate the commit.. definitely a big improvement. |
ghutchis
added a commit
that referenced
this pull request
Feb 5, 2015
Use WebGL ChemDoodle viewer if supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should gracefully fall back to the old style viewer in older versions of OS X, but I haven't tested.
There are a few other minor changes as well, each individual commit should be fairly self explanatory.