Wrong openbabel2 macro output + missing license

[ghutchis]

cmake/modules/FindOpenBabel2.cmake tells "Could NOT find OpenBabel2", which is not true if Openbabel 2.0 is installed (it's just not new enough). You should fix this to output the real issue.

I'm further suprised by the Windows registry path: HKEY_CURRENT_USER\SOFTWARE\OpenBabel\ 2.0.2. If 2.1 is requirered, is this path correct?

Further the file (and another too) refers to COPYING-CMAKE-SCRIPTS, which is not shipped with the source.

Reported by: dleidert

[ghutchis]

Logged In: YES
user_id=684210
Originator: NO

I just synced avogadro with kdeedu. The FindOpenBabel2.cmake is maintained by me and (me importantly) by Laurent Montel, a CMake-genius. I hope this fixes the issues.

Daniel, could you (re)test?

Carsten

Original comment by: @cniehaus

[ghutchis]

Logged In: YES
user_id=684210
Originator: NO

Further the file (and another too) refers to COPYING-CMAKE-SCRIPTS, which
is not shipped with the source.

I just added that file.

Original comment by: @cniehaus

[ghutchis]

Logged In: YES
user_id=1102637
Originator: YES

Well, I don't understand the lines 62-70 (I do not use cmake). Why there are

if { if { } }

constructs. I mean, where are the Openbabel2_FIND_* variables are filled with values and why do you need to check them inside the OPENBABEL2_FOUND check? This check will still fail, because pkg-config exits with "1", if the package does not exist or at least not in the requiered version. From what I read, these extra-checks seem useless to me. And the error still says:

message(FATAL_ERROR "Could NOT find OpenBabel2")

which is IMO the wrong message, if Openbabel 2.1 is required. I mean the test fails, if 2.0 is installed too. And then this message tells the wrong information to the user. The message should IMHO say at least "Could NOT find OpenBabel2 $REQUIRED_VERSION".

BTW: IMHO you could make your macro more variable, if you define an argument, that is the required openbabel version. And you could do a 3-way check: a) installed in required version, b) installed, but not in required version and c) not installed/not found.

Original comment by: dleidert

[ghutchis]

Logged In: YES
user_id=21420
Originator: NO

This seems to be solved in the current SVN code, as of revision 620.

I'm marking this closed.

Original comment by: @ghutchis