Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify anonymization of an article #100

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Simplify anonymization of an article #100

merged 1 commit into from
Jul 11, 2023

Conversation

csware
Copy link
Contributor

@csware csware commented May 6, 2023

Added a new documentclass option anonymous and new macro \anon fo simplifying anonymization. I saw this in the acmart and found this really useful.

The \thanks macro could be replaced with a placeholder... But this doesn't seem to be an issue ATM as thanks seems to be broken anyways.

@csware csware force-pushed the anonymous branch 4 times, most recently from 012e179 to e35a8ff Compare May 6, 2023 16:15
@csware
Copy link
Contributor Author

csware commented May 7, 2023

@sieversMartin I rebased this.

How to build lni.pdf?

@sieversMartin
Copy link
Member

pdflatex lni.dtx

@csware csware force-pushed the anonymous branch 2 times, most recently from e485cba to 6c60022 Compare May 13, 2023 15:05
@koppor
Copy link
Member

koppor commented Jul 10, 2023

How to get PDFs?

I merged main into this. Now, the build PDF is available at the job output: https://github.com/gi-ev/LNI/actions/runs/5505788054?pr=100

image

image

Hint on local execution

Be careful when running pdflatex lni.dtx: It overwrites (!) the files you modified. (This is the way back then package authoring was intended).

What I am doing is to work on the generated files, stage them and then port the changed to lni.dtx, regenerate. If any diff is shown by git gui, I reiterate on adapting lni.dtx. Refs #108.

Sneak preview on your change

image

@csware
Copy link
Contributor Author

csware commented Jul 10, 2023

@koppor Updated.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@koppor koppor merged commit b237100 into gi-ev:main Jul 11, 2023
1 check passed
@koppor
Copy link
Member

koppor commented Jul 11, 2023

CHANGELOG.md entry added at 6035f20

@koppor
Copy link
Member

koppor commented Jul 11, 2023

Side note: No need to force-push. I am doing a squash-merge (creating one commit in the main branch) at the merge. - Having separate commits in the PR helps to review. In the concrete case, I spent five minutes searching for the & in the diff until I realized that there was a force push ^^.

@csware
Copy link
Contributor Author

csware commented Jul 11, 2023

I prefer clean history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants