[Windows] psutil.swap_memory() show swap instead of committed memory #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
force-pushed
the
fix-win-swap
branch
3 times, most recently
from
2bf3e7c
to
e166a62
Compare
Signed-off-by: David Knaack <davidkna@users.noreply.github.com>
dbwiddis
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
.ullTotalPageFileand.ullAvailPageFileinclude both the swap and physical memory so in order to get the correct swap memory values the physical memory size/usage needs to be subtracted.https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/ns-sysinfoapi-memorystatusex
.ullTotalPageFileis "The current committed memory limit". It mirrors the value of.CommitLimit * .PageSizefromPERFORMANCE_INFORMATION"The current maximum number of pages that can be committed by the system without extending the paging file". I think this confirms the value refers to committed or total system memory including both the pagefile and hardware memory..ullAvailPageFile - .ullAvailPhysalso aligns with the value Windows reports for the page file size in the UI for me.