add test for anti_flood_ftpd.py demo script.
#416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
reviewed
Mar 10, 2017
Makefile
Outdated
| @@ -106,6 +106,9 @@ test-ioloop: install | |||
| test-servers: install | |||
| $(PYTHON) pyftpdlib/test/test_servers.py | |||
|
|
|||
| test-servers: install | |||
| $(PYTHON) pyftpdlib/test/test_demo_scripts.py | |||
|
|
|||
There was a problem hiding this comment.
There is already a make command with this name. You should rename this to test-demos
giampaolo
reviewed
Mar 10, 2017
pyftpdlib/test/__init__.py
Outdated
| super(ThreadedTestFTPd, self).__init__( | ||
| poll_interval=self.poll_interval) | ||
| if handler: | ||
| self.handler = handler |
There was a problem hiding this comment.
I prefer not to do this. You can simply setattr the handler later against this object
|
@giampaolo i fix the problems. i change the |
|
@giampaolo any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also add tests for other demo scripts soon.