Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to have more than one carousel per page #10

Closed
GianFF opened this issue May 13, 2019 · 0 comments
Closed

Add the ability to have more than one carousel per page #10

GianFF opened this issue May 13, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@GianFF
Copy link
Owner

GianFF commented May 13, 2019

There is a bug when you have more than one carousel in the same page:

  • suppose you have carousel-1 and carousel-2, when clicking on the right arrow on carousel-1 then carousel-2 will also be right clicked.
  • that is because we are emitting an event on the bus with a common name, we need to specify who has emitted that event.
@GianFF GianFF added the bug Something isn't working label May 13, 2019
GianFF added a commit that referenced this issue May 13, 2019
@GianFF
#10 - Add id to the emitted event in order to prevent multiple carous…
45342a7 
…el in the same page react for the same event
GianFF added a commit that referenced this issue May 13, 2019
@GianFF
Merge pull request #11 from GianFF/10-carouse-bug
5f5c449 
#10 - fix multiple carousel in the same page bug
@GianFF GianFF closed this as completed May 13, 2019
GianFF added a commit that referenced this issue May 13, 2019
@GianFF
Merge pull request #12 from GianFF/10-carouse-bug
ec1897c 
#10 - carousel bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GianFF