Skip to content

Commit

Permalink
Move LookupReferencesManager to ServiceClient.
Browse files Browse the repository at this point in the history
Continuing the work from apache#12696. Also in this patch:

1) Extract the nice request builder stuff from the SeekableStream async
   client, and put it in a more broadly useful ServiceCallBuilder.

2) Slight behavior change to ServiceClient#request; switch to unchecked
   get instead of checked get. Unchecked get is more commonly wanted.
   Callers can get checked get if they need it by using asyncRequest.
  • Loading branch information
gianm committed Jul 28, 2023
1 parent 46ecc6b commit ac1292f
Show file tree
Hide file tree
Showing 18 changed files with 590 additions and 360 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public <RetType> RetType submit(TaskAction<RetType> taskAction) throws IOExcepti
Thread.currentThread().interrupt();
throw new RuntimeException(e);
}
catch (ExecutionException e) {
catch (Exception e) {
if (e.getCause() instanceof HttpResponseException) {
// Rewrite the error to be slightly more useful: point out that there may be information in the Overlord logs.
final StringFullResponseHolder fullResponseHolder = ((HttpResponseException) e.getCause()).getResponse();
Expand Down
Loading

0 comments on commit ac1292f

Please sign in to comment.