Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post hook hack as workaround #89

Merged
merged 8 commits into from Aug 3, 2022
Merged

Post hook hack as workaround #89

merged 8 commits into from Aug 3, 2022

Conversation

pipo02mix
Copy link
Contributor

@pipo02mix pipo02mix commented Aug 3, 2022 •
edited

  • This repository allows merge commits, if you're creating a Release, make sure to select 'Squash and merge'
  • When merging subtree updates, it is important to select 'Create a merge commit' when merging.

Towards giantswarm/roadmap#1174

Checklist

  • Automated test are working (for chart changes)
  • I am confident my changes don't break existing installations (for chart changes)
  • Changelog entry has been added

@pipo02mix pipo02mix requested a review from a team as a code owner August 3, 2022 08:02
@pipo02mix pipo02mix self-assigned this Aug 3, 2022
ubergesundheit
ubergesundheit approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested

@pipo02mix pipo02mix merged commit 5ceaa5b into master Aug 3, 2022
@pipo02mix pipo02mix deleted the post-hook-hack branch August 3, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

Assignees

@pipo02mix pipo02mix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pipo02mix @ubergesundheit