Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for linkerd-viz app #2320

Closed
4 tasks done
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 3 comments
Closed
4 tasks done
Tracked by #2066

Implement best practices for linkerd-viz app #2320

LolloneS opened this issue Apr 5, 2023 · 3 comments
Assignees

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@mcharriere
Copy link

We'll contribute PDB to upstream: linkerd/linkerd2#11248

@mcharriere
Copy link

mcharriere commented Aug 15, 2023

the app can scale horizontally based on Custom Metrics (if it makes sense)

It doesn't make much sense in this case, as scaling is largely dependent on cluster size / tap usage. We might need to revisit scaling in the future, depending on customer use.

the app does not use emptyDir volumes if not strictly necessary

it does require it indirectly, as all linkerd.

@mcharriere
Copy link

1.2.0 released including PDB. Upstream PR is still open, hopefully it gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants