GenericVBO changes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VBO into the OpenGL namespace
|
Looks good, thanks! Since you've broken IGenericVBO into its own file I would suggest doing this with IGenericVAO, etc (if relevant to future PRs). I also noticed the |
|
After the #3 PR has been merged I'll go through and try to separate classes into their own files instead of having several class definitions in a single file. So no worries if any get missed during these PRs. It's easy to take care of later. |
giawa
added a commit
that referenced
this pull request
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of 3 from PR #24.
Add new GenericVBO constructor.
Generic VAOs uses the new constructor.
Moved IGenericVBO into the OpenGL namespace.
There is a few more changes i would like to make but i want to hear your opinion first. I want to move GenericVBO into the OpenGL namespace as well. If the user has to use it then it should probably be there.
I would also like to change the name of GenericVBO. The only difference between VBO and GenericVBO is that GenericVBO contains a name. So i would like to change the name of GenericVBO and IGenericVBO to something like NamedVBO and INamedVBO. Both VBO and GenericVBO are generic so having generic in the name isn't very descriptive. Afaik i don't think this change would break much as GenericVBO was only recently added.