Vector Refactorings #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when system.numerics.vector is unavailable Always enable extension methods so that we have a single codebase for those methods, and throw an Exception when an index is out of range for the Get methods.
|
I think this should be merged. Once it is, I will finish my matrix pull request. |
TheAIBot
approved these changes
Sep 3, 2020
|
Awesome, thanks for taking a look! I implemented the suggestions you made. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Notes
This change adds
Getto theVector2class, removes code duplication, addsCopyTofor vectors without System.Numerics and adds an exception forGetif the index is out of range.Testing
Limited testing - made sure it compiled and ran a few local tests.