Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /[book] page to /[book] and /[book]:[bookHadith] #7

Closed
thecashewtrader opened this issue Nov 24, 2022 · 0 comments · Fixed by #10
Closed

Move /[book] page to /[book] and /[book]:[bookHadith] #7

thecashewtrader opened this issue Nov 24, 2022 · 0 comments · Fixed by #10

Comments

@thecashewtrader
Copy link
Contributor

Currently, in the book page, we are manually checking for a : and splitting, rendering different versions of the page. If we split the route into two: /[book] and /[book]:[bookHadith], it would vastly simplify the pages, in addition to allowing for easier implementation of <title> tags, OpenGraph embeds, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant