fix #100 and add unittest for layergroup methods #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamtekson
reviewed
Feb 10, 2023
geo/Geoserver.py
Outdated
| ) -> str: | ||
| try: | ||
| if self.get_layergroup(layer_name=layergroup_name) is None: | ||
| try: |
There was a problem hiding this comment.
Why do we need this block of try, and except blocks? I didn't see any required information inside the try block. I think it should remove this block.
There was a problem hiding this comment.
The idea was to raise the exact error message we had here before. I have removed it now, so you now get whatever error message ist returned by get_layergroup.
tests/.env_template
Outdated
| @@ -0,0 +1,4 @@ | |||
| # Login information for geoserver | |||
| GEOSERVER_URL="http://localhost:8050/geoserver" | |||
There was a problem hiding this comment.
Please change the default value of geoserver port to 8080
Thanks for the friendly feedback :) |
iamtekson
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @iamtekson
I've fixed #100 and added some unittests during development to be sure it all works as expected (sorry for using unittest instead of pytest, it's a bit more intuitive to me - I can also remove the test if it doesn't suit your concept).