Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup automatic tests #151

Merged
merged 9 commits into from
Jun 2, 2024
Merged

setup automatic tests #151

merged 9 commits into from
Jun 2, 2024

Conversation

iboates
Copy link
Collaborator

@iboates iboates commented May 16, 2024

I have set up a Github action pipeline to run tests for every push & PR to master, as well as once a day.

I have disabled a lot of tests because they seem to be using other, less popular testing frameworks, or are dependent on local data.

I am interested in building out more tests to cover individual functionalities more comprehensively, and to use it as a springboard to make more comprehensive coverage of the geoserver API.

Do you have any objections to me removing or otherwise heavily modifying the existing tests?

by the way, I tried to write a pipeline to work on Windows as well, but I really had no idea what I was doing. I couldn't use docker containers, and I was making progress on installing things manually, but ultimately I decided it's not worth the effort. Maybe someone else can add Windows support in the future. My work is still there, just commented out.

.github/workflows/python-test.yml Outdated Show resolved Hide resolved

- name: Install dependencies
run: |
sudo apt-add-repository ppa:ubuntugis/ubuntugis-unstable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to always test against unstable? It sounds like this would be better tested in a matrix configuration. https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is not actually selecting the OS version, but rather installing the necessary system binaries for GDAL, which is required for some Python GIS libraries. But when you pointed this out I noticed that it would indeed be better to use the stable ppa, so I updated it.

I think that it is not necessary to test on different OS versions, since this library mostly does just handle a lot of REST requests. However, I liked the idea of using a strategy matrix to test against different Python verisons, so I made it do that.

Thoughts? Counterpoints?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iboates Please excuse the delay, I've been out of the office for the last week!

I agree with you on the OS point; Unless we're testing things that are platform-dependent, we don't really need to test different OSes. Typically, if a package claims to support a Python version, we should be testing said version via a matrix to be sure it's supported (sometimes dependencies drop the lowest version without any announcement, etc.). Changes here look good to me!

.idea/.gitignore Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .idea folder should be added to the .gitignore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, not sure why it happened now and not with all my other commits

@iamtekson
Copy link
Collaborator

Thanks for the PR @iboates and for the review @Zeitsperre!

Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@iamtekson
Copy link
Collaborator

Is it okay to merge now, or are you still modifying something?

@iboates
Copy link
Collaborator Author

iboates commented Jun 2, 2024

Is it okay to merge now, or are you still modifying something?

Ok to merge

@iamtekson iamtekson merged commit 096ca0a into gicait:master Jun 2, 2024
5 checks passed
@iamtekson
Copy link
Collaborator

Hi @iboates & @Zeitsperre, I have invited you both for this repository maintainer. Please accept my invitation. Thank you very much for all of your efforts and contributions to this package. It is a lot more enhanced than before.

@iamtekson iamtekson mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants