Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 86 missing application json #96

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Issue 86 missing application json #96

merged 2 commits into from
Jan 14, 2023

Conversation

Kilometerfresserin
Copy link
Contributor

Fixes the json-problem with create_coveragestore mentioned in #86.

I have however not checked if there are any other methods that still may have the same problem.

iamtekson
iamtekson approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you tested whether this will fix the #86 or not?

@iamtekson
Copy link
Collaborator

For now I just merge this PR.

@iamtekson iamtekson merged commit 55cc591 into gicait:master Jan 14, 2023
@Kilometerfresserin
Copy link
Contributor Author

Thanks :)

@Kilometerfresserin Kilometerfresserin deleted the issue_86_missing_application_json branch January 16, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamtekson iamtekson iamtekson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kilometerfresserin @iamtekson