Layergroup creation bugfix

[julescarpentier]

Hi,

Geoserver now returns 404 HTTP error code when requesting for a resource that doesn't exists (instead of 200 OK with empty JSON before I imagine)

This impacts the layergroup creation method as it checks a layergroup with the same name doesn't exists already.

Best regards

[iamtekson]

That's the correct status code for non-existing layergroups. I think it is not necessary to bypass the 404 error.

[julescarpentier]

I agree, 404 is the correct status code for non-existing layergroups.
If no bypass, then the check for an existing layergroup with that name should be removed. Because as it is, when creating a new layergroup, the check expects None from get_layergroup() yet this function raises an Exception since the layer doesn't exist.

[Kilometerfresserin]

I'm not sure whether it is smart to remove the check entirely, because this will cause issues for any code that assumes it will get an error if the layergroup exists already.

I would suggest to check for an exception in get_layergroup, like (I don't know if this is the most pythonic solution, but it works):

            # check if it already exist in Geoserver
            try: 
                existing_layer_group = self.get_layergroup(name)
            except:
                existing_layer_group = None

            if existing_layer_group is not None:
                raise Exception(
                    f"Layergroup: {name} already exists in Geoserver instance"
                )

[iamtekson]

Yes, I think it is the correct way of fixing for now. Can you please update this PR with above suggestion? @julescarpentier