Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package entrypoint (dist/index.jsdist/main.js) #38

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

kachkaev
Copy link
Member

@kachkaev kachkaev commented Nov 5, 2022

index files are somewhat an anti-pattern in modern JS. Renaming index to main does not allow to rely on folder path resolution, which improves alignment with ESM. This will be useful in the future.

This PR does not affect end-users of the package.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 94.68% // Head: 94.68% // No change to project coverage 👍

Coverage data is based on head (ec03304) compared to base (e1ebaa0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files           5        5           
  Lines          94       94           
  Branches       14       14           
=======================================
  Hits           89       89           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/main.ts 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kachkaev kachkaev merged commit c102a86 into main Nov 5, 2022
@kachkaev kachkaev deleted the entrypoint branch November 5, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant