Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execa timeout #39

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Add execa timeout #39

merged 1 commit into from
Nov 5, 2022

Conversation

kachkaev
Copy link
Member

@kachkaev kachkaev commented Nov 5, 2022

If elm-format binary fails to install, calls to execa end up unterminated. Adding timeout prevents plugin from hanging forever.

This edge case has been spotted in CI recently and should be quite rare.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 94.68% // Head: 94.68% // No change to project coverage 👍

Coverage data is based on head (c11589c) compared to base (c102a86).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files           5        5           
  Lines          94       94           
  Branches       14       14           
=======================================
  Hits           89       89           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/helpers.ts 88.88% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kachkaev kachkaev changed the title Add execa timeout Add execa timeouts Nov 5, 2022
@kachkaev kachkaev merged commit 0780588 into main Nov 5, 2022
@kachkaev kachkaev changed the title Add execa timeouts Add execa timeout Nov 5, 2022
@kachkaev kachkaev deleted the execa-timeout branch November 5, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant