Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shell versions 44 and 45 #65

Merged
merged 1 commit into from
May 14, 2023
Merged

Conversation

cewbdex
Copy link
Contributor

@cewbdex cewbdex commented Apr 11, 2023

Fixes #62 with a release afterwards.

@BloodyIron
Copy link

Looking for Gnome 44 support to hit main extension repo. Any anticipated timeline on that? :)

@cewbdex
Copy link
Contributor Author

cewbdex commented May 2, 2023

You have to ask @gicmo , I don't remember why I added 45, that version does not exist, it was probably a mistake, will remove soon.

@lukurde
Copy link

lukurde commented May 14, 2023

Hello all. Gnome 44 has been out for almost 2 months now and the plugin still doesn't support it. The last version listed on extensions.gnome.org shows Gnome 42 which is 2 releases behind. The plugin shipped with Fedora 38 doesn't support Gnome 44 shipped with said OS... Can we bump the version or is there a blocker behind it?

@benzea benzea merged commit 4dad4a9 into gicmo:master May 14, 2023
@lukurde
Copy link

lukurde commented May 15, 2023

Hey @benzea, I don't know if that was the intent but you've also merged support for the future version of Gnome 45 which is scheduled to be released in September.

@cewbdex cewbdex deleted the patch-1 branch May 16, 2023 10:38
@yochananmarqos
Copy link

yochananmarqos commented Aug 19, 2023

@cewbdex Please remove the false GNOME 45 compatibility. See #70

@cewbdex
Copy link
Contributor Author

cewbdex commented Aug 20, 2023

I can't do anything further, it was merged before I could implement a fix, I just opened PR, so can you do.

@yochananmarqos
Copy link

@cewbdex Oops, I meant to tag @benzea.

fjsevilla-dev added a commit that referenced this pull request Aug 24, 2023
Support for version 45 was erroneously added at #65 . Support for version 45 brings changes that break compatibility with previous versions.
@fjsevilla-dev
Copy link
Collaborator

@yochananmarqos I have just fixed the mistake. Now I'm going to see if it's too much work to support the extension to gnome-shell 45...

@fjsevilla-dev fjsevilla-dev mentioned this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish GNOME 43 version to extensions.gnome.org
6 participants