Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom property on options optional #3

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

zbarbuto
Copy link

For instances where you have a custom controller that implements CrudController<T> with a custom endpoint that wants to use TypeOrmCrudService<T> it's nice to just be able to, for example, call

await this.service.getMany({
 options: { query: { limit: 10 } }
})

Without being required to pass in operators. At the moment the above would error with can not read property 'custom' of undefined

@coveralls
Copy link

coveralls commented Jun 29, 2022

Pull Request Test Coverage Report for Build 2580929203

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 99.782%

Totals Coverage Status
Change from base Build 2575515495: -0.2%
Covered Lines: 1194
Relevant Lines: 1194

💛 - Coveralls

@zaro zaro merged commit 83426c8 into gid-oss:master Jun 29, 2022
@zaro
Copy link
Member

zaro commented Jun 29, 2022

@zbarbuto Thank you, I think the change makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants