Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying the content-type #115

Closed
brettcannon opened this issue Apr 19, 2020 · 1 comment · Fixed by #131
Closed

Support specifying the content-type #115

brettcannon opened this issue Apr 19, 2020 · 1 comment · Fixed by #131
Labels
enhancement

Comments

@brettcannon
Copy link
Collaborator

Uploading a release asset expects an appropriate content-type for what is uploaded. Currently GitHubAPI always assumes a JSON payload.
@certik
Copy link

certik commented Aug 18, 2020

Indeed, this line currently sets it as a JSON payload:

https://github.com/brettcannon/gidgethub/blob/e751664d95917dbdb856c382bfe2f4655e2a83c1/gidgethub/abc.py#L98

Mariatta added a commit that referenced this issue Aug 18, 2020
@Mariatta
Allow passing content-type header to GitHubAPI.POST
987f69b 
When the content-type is passed, the raw body is used in the request.
The default content-type is json, and the body would be parsed to JSON format.

Updated documentation and changelog.

Closes #115
@Mariatta Mariatta mentioned this issue Aug 18, 2020
Merged
Mariatta added a commit that referenced this issue Aug 23, 2020
@Mariatta
Default to JSON content type if not passed
9923dc5 
Closes #115
Mariatta added a commit that referenced this issue Aug 23, 2020
@Mariatta @brettcannon
Allow passing content-type header to GitHubAPI.POST (#131)
27c104d 
* Allow passing content-type header to GitHubAPI.POST

When the content-type is passed, the raw body is used in the request.
The default content-type is json, and the body would be parsed to JSON format.

Updated documentation and changelog.

Closes #115

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow passing content-type header to GitHubAPI.POST gidgethub/gidgethub
2 participants
@certik @brettcannon