Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable large values for the limit query #11

Open
ayaanqui opened this issue Nov 29, 2021 · 0 comments
Open

Disable large values for the limit query #11

ayaanqui opened this issue Nov 29, 2021 · 0 comments
Labels
🐞 bug Something isn't working 🛒 products

Comments

@ayaanqui
Copy link
Member

The limit query on /products can accept any numeric value for the limit query. This can lead to crashes as it can be called with a very large value and this significantly slow or even crash the server. See:

api/src/products/products.controller.ts

Line 25 in c1cfc37

@Query('limit') limit: number = 50,

@ayaanqui ayaanqui added 🐞 bug Something isn't working 🛒 products labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 🛒 products
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayaanqui