Revert "Revert "Use sync-exec for node 0.10" (lerna#242)"

This reverts commit 7eb4763.

.travis.yml

@@ -8,6 +8,7 @@ cache:
   - node_modules
 
 node_js:
+ - "0.10"
  - "0.12"
  - "4"
  - stable

package.json

@@ -37,7 +37,8 @@
     "progress": "^1.1.8",
     "rimraf": "^2.4.4",
     "semver": "^5.1.0",
-    "signal-exit": "^2.1.2"
+    "signal-exit": "^2.1.2",
+    "sync-exec": "^0.6.2"
   },
   "bin": {
     "lerna": "./bin/lerna.js"

src/ChildProcessUtilities.js

@@ -1,5 +1,6 @@
 import child from "child_process";
 import objectAssign from "object-assign";
+import syncExec from "sync-exec";
 
 export default class ChildProcessUtilities {
   static exec(command, opts, callback) {
@@ -21,9 +22,15 @@ export default class ChildProcessUtilities {
   }
 
   static execSync(command) {
-    return child.execSync(command, {
-      encoding: "utf8"
-    }).trim();
+    if (child.execSync) {
+      return child.execSync(command, {
+        encoding: "utf8"
+      }).trim();
+    } else {
+      return syncExec(command, {
+        encoding: "utf8"
+      }).stdout.trim();
+    }
   }
 
   static spawn(command, args, opts, callback) {

test/UpdatedCommand.js

@@ -2,13 +2,16 @@ import assert from "assert";
 import child from "child_process";
 import path from "path";
 import fs from "fs";
+import syncExec from "sync-exec";
 
 import UpdatedCommand from "../src/commands/UpdatedCommand";
 import exitWithCode from "./_exitWithCode";
 import initFixture from "./_initFixture";
 import logger from "../src/logger";
 import stub from "./_stub";
 
+const execSync = (child.execSync || syncExec);
+
 describe("UpdatedCommand", () => {
 
   /** =========================================================================
@@ -23,10 +26,10 @@ describe("UpdatedCommand", () => {
     });
 
     it("should list changes", done => {
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-2/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-2/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {});
 
@@ -46,10 +49,10 @@ describe("UpdatedCommand", () => {
     });
 
     it("should list changes with --force-publish *", done => {
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-2/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-2/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {
         forcePublish: "*"
@@ -71,10 +74,10 @@ describe("UpdatedCommand", () => {
     });
 
     it("should list changes with --force-publish [package,package]", done => {
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {
         forcePublish: "package-2,package-4"
@@ -103,11 +106,11 @@ describe("UpdatedCommand", () => {
       };
       fs.writeFileSync(lernaJsonLocation, JSON.stringify(lernaJson, null, 2));
 
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-2/ignored-file"));
-      child.execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-2/ignored-file"));
+      execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {});
 
@@ -139,10 +142,10 @@ describe("UpdatedCommand", () => {
     });
 
     it("should list changes", done => {
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {});
 
@@ -162,10 +165,10 @@ describe("UpdatedCommand", () => {
     });
 
     it("should list changes with --force-publish *", done => {
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-2/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-2/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {
         forcePublish: "*"
@@ -187,10 +190,10 @@ describe("UpdatedCommand", () => {
     });
 
     it("should list changes with --force-publish [package,package]", done => {
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-4/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-4/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {
         forcePublish: "package-2"
@@ -219,11 +222,11 @@ describe("UpdatedCommand", () => {
       };
       fs.writeFileSync(lernaJsonLocation, JSON.stringify(lernaJson, null, 2));
 
-      child.execSync("git tag v1.0.0");
-      child.execSync("touch " + path.join(testDir, "packages/package-2/ignored-file"));
-      child.execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
-      child.execSync("git add -A");
-      child.execSync("git commit -m 'Commit'");
+      execSync("git tag v1.0.0");
+      execSync("touch " + path.join(testDir, "packages/package-2/ignored-file"));
+      execSync("touch " + path.join(testDir, "packages/package-3/random-file"));
+      execSync("git add -A");
+      execSync("git commit -m 'Commit'");
 
       const updatedCommand = new UpdatedCommand([], {});
 

test/_initFixture.js

@@ -2,6 +2,7 @@ import rimraf from "rimraf";
 import child from "child_process";
 import path from "path";
 import cpr from "cpr";
+import syncExec from "sync-exec";
 
 const tmpDir = path.resolve(__dirname, "../tmp");
 const originalCwd = process.cwd();
@@ -29,7 +30,7 @@ export default function initFixture(fixturePath, callback) {
   }, err => {
     if (err) return callback(err);
     process.chdir(testDir);
-    child.execSync("git init . && git add -A && git commit -m 'Init commit'");
+    (child.execSync || syncExec)("git init . && git add -A && git commit -m 'Init commit'");
     callback();
   });