Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod.exs settings when using React with Mix #17

Closed
wants to merge 2 commits into from

Conversation

shibani
Copy link

@shibani shibani commented Aug 22, 2018

Added in documentation to include server:true in config/prod.exs if project does not use static buildpack.

If using React in a project where Brunch has been removed and Webpack has been added in instead
If using Heroku Buildpack for Elixir but not Phoenix Static Buildpack,
`server:true` should be added to `config/prod.exs`
@jesseshieh
Copy link
Contributor

Thanks for the pull request @shibani. I think it's great to include this in the documentation, but I think it probably makes more sense as it's own section rather than in the middle of the primary guide. I'm not sure how many people use webpack and don't use the phoenix buildpack. What do you think?

@shibani
Copy link
Author

shibani commented Aug 27, 2018

Hi Jesse,

Sorry for the delayed response. I can create another section for this if you like, I think I was unclear when I got to the Mix vs. Distillery sections. If using Mix, the user is never instructed to create a .buildpacks file, whereas if using Distillery they are (Specify Buildpacks to Compile and Build Releases looks like a subsection under Distillery). Is a .buildpacks file necessary in both cases? From what I understand, you would say yes?

Also are the 4 buildpacks specified necessary for both types of tools then, Mix and Distillery?

Thanks,
Shibani

@jesseshieh
Copy link
Contributor

Hey Shibani, Gigalixir tries to detect what type of app you are running to pick your buildpacks for you so the .buildpacks file is only necessary if you need something custom. For example, if you don't want the phoenix static buildpack. I probably could remove the buildpack section in the distillery instructions.

For reference: https://github.com/gigalixir/gigalixir-buildpack-elixir/blob/master/bin/compile#L7

@shibani
Copy link
Author

shibani commented Aug 28, 2018

With the goal of greater clarity in mind, I think adding a quick sentence about the buildpacks in the Mix section and leaving the Distillery section as is might make the docs clearer.

@jesseshieh
Copy link
Contributor

I think a quick sentence is a good idea that maybe links to more details in a separate section.

@shibani
Copy link
Author

shibani commented Aug 29, 2018

Let me know if I can help writing it up.

@jesseshieh
Copy link
Contributor

That would be very much appreciated!

@jesseshieh
Copy link
Contributor

Closing as this is pretty old now

@jesseshieh jesseshieh closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants