Regression: CHROMEDRIVER_FILEPATH doesn't work

[jan-molak]

Hey @giggio

It looks like v122.0.0 introduced a regression (also present in v123) similar to #424, where specifying CHROMEDRIVER_FILEPATH breaks the installation process.

I believe the culprit is the return statement on line 66:

node-chromedriver/install.js

Lines 61 to 79 in 85cd3fa

	if (!chromedriverIsAvailable) {
	console.log('Current existing ChromeDriver binary is unavailable, proceeding with download and extraction.');
	const configuredfilePath = process.env.npm_config_chromedriver_filepath || process.env.CHROMEDRIVER_FILEPATH;
	if (configuredfilePath) {
	console.log('Using file: ', configuredfilePath);
	return configuredfilePath;
	}
	if (useLegacyMethod)
	await this.downloadFileLegacy(legacyCdnUrl, downloadedFile, chromedriverVersion);
	else
	await this.downloadFile(cdnUrl, downloadedFile, chromedriverVersion, platform);
	await this.extractDownload(extractDirectory, chromedriverBinaryFilePath, downloadedFile);
	}
	const libPath = path.join(__dirname, 'lib', 'chromedriver');
	await this.copyIntoPlace(tmpPath, libPath);
	this.fixFilePermissions();
	console.log('Done. ChromeDriver binary available at', helper.path);
	} catch (err) {
	console.error('ChromeDriver installation failed', err);

This return statement prevents the script from proceeding to line 75 and copying the existing user-specified binary to chromedriver/lib/chromedriver:

node-chromedriver/install.js

Lines 75 to 77 in 85cd3fa

	await this.copyIntoPlace(tmpPath, libPath);
	this.fixFilePermissions();
	console.log('Done. ChromeDriver binary available at', helper.path);

Since the binary is never copied to the correct destination, calling require('chromedriver').path returns a path that points to a non-existent location, which then confuses automation frameworks:

node-chromedriver/lib/chromedriver.js

Lines 48 to 52 in 85cd3fa

	module.exports = {
	path: crpath,
	version,
	start,

I believe that to solve this, the install script should copy the user-specified binary to the expected location.

[giggio]

Yes, this is most likely a bug. It came from the refactoring I did earlier. I see you submitted a PR, I'll take a look into it.

[giggio]

I just fixed it and will release momentarily. If the fix does not work for you, please let me know.

[jan-molak]

Thanks @giggio, I'll try it in a moment 👍

[jan-molak]

Looking good, thanks for the quick fix, @giggio!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.