Add more unit tests

- Missed some number types in ExampleNumberTest - Increase coverage for PrefixTimeZonesMap
giggsey · Aug 6, 2015 · 9ad9a07 · 9ad9a07
1 parent 319fd64
commit 9ad9a07
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/Tests/libphonenumber/Tests/core/ExampleNumbersTest.php b/Tests/libphonenumber/Tests/core/ExampleNumbersTest.php
@@ -60,6 +60,15 @@ public function testFixedLine($region)
         $this->checkNumbersValidAndCorrectType(PhoneNumberType::FIXED_LINE, $fixedLineTypes, $region);
     }
 
+    /**
+     * @dataProvider regionList
+     */
+    public function testFixedLineOrMobile($region)
+    {
+        $numberTypes = array(PhoneNumberType::FIXED_LINE, PhoneNumberType::FIXED_LINE_OR_MOBILE);
+        $this->checkNumbersValidAndCorrectType(PhoneNumberType::FIXED_LINE_OR_MOBILE, $numberTypes, $region);
+    }
+
     private function checkNumbersValidAndCorrectType($exampleNumberRequestedType, $possibleExpectedTypes, $regionCode)
     {
         $exampleNumber = $this->phoneNumberUtil->getExampleNumberForType($regionCode, $exampleNumberRequestedType);
@@ -138,6 +147,15 @@ public function testVoicemail($region)
         $this->checkNumbersValidAndCorrectType(PhoneNumberType::VOICEMAIL, $voicemailTypes, $region);
     }
 
+    /**
+     * @dataProvider regionList
+     */
+    public function testPersonalNumber($region)
+    {
+        $numberTypes = array(PhoneNumberType::PERSONAL_NUMBER);
+        $this->checkNumbersValidAndCorrectType(PhoneNumberType::PERSONAL_NUMBER, $numberTypes, $region);
+    }
+
     /**
      * @dataProvider regionList
      */

diff --git a/Tests/libphonenumber/Tests/timezone/UKTest.php b/Tests/libphonenumber/Tests/timezone/UKTest.php
@@ -4,9 +4,14 @@
 
 use libphonenumber\PhoneNumber;
 use libphonenumber\PhoneNumberToTimeZonesMapper;
+use libphonenumber\PhoneNumberUtil;
 
 class UKTest extends \PHPUnit_Framework_TestCase
 {
+    public function setUp()
+    {
+        PhoneNumberUtil::resetInstance();
+    }
 
     public function testGBNumber()
     {
@@ -16,4 +21,13 @@ public function testGBNumber()
         $timeZone = PhoneNumberToTimeZonesMapper::getInstance();
         $this->assertEquals(array("Europe/London"), $timeZone->getTimeZonesForNumber($number));
     }
+
+    public function testNonGeocodableNumber()
+    {
+        $number = new PhoneNumber();
+        $number->setCountryCode(44)->setNationalNumber(8001111);
+
+        $timeZone = PhoneNumberToTimeZonesMapper::getInstance();
+        $this->assertEquals(array("Europe/London"), $timeZone->getTimeZonesForNumber($number));
+    }
 }