Tests fail on HHVM

[giggsey]

From memory, this is an issue with the Regex used.

Need to write a simple testable script with a failing number

[joacub]

in php7 fail this

[giggsey]

@joacub What do you mean?

[joacub]

Fail macher regex expresion, return 502 error, the error not is manage

[giggsey]

@joacub Sorry, but this still doesn't make much sense.

Can you post a code sample that is causing an error, and the full error message you are getting.

[joacub]

The cose error is :

    private function doMatch($type = 'find')
    {
        $final_pattern = '(?:' . $this->pattern . ')';
        switch ($type) {
            case 'matches':
                $final_pattern = '^' . $final_pattern . '$';
                break;
            case 'lookingAt':
                $final_pattern = '^' . $final_pattern;
                break;
            case 'find':
            default:
                // no changes       
                break;
        }
        $final_pattern = '/' . $final_pattern . '/x';
        return (preg_match($final_pattern, $this->subject, $this->groups, PREG_OFFSET_CAPTURE) == 1) ? true : false;
    }

The php7 not response error, php7 crashed

[giggsey]

What functions are you calling that get to this function? What version of PHP are you running?

[joacub]

The php version is 7.0.1, test with This Number 6161217474 and in us locale

[giggsey]

I just upgraded the demo to support both PHP 5.6 and PHP7.

When trying your number in the PHP 7 demo, it works fine for me: http://libphonenumber-for-php.giggsey.net/?phonenumber=6161217474&country=US&language=&region= (the footer on the page shows the php version)

[joacub]

How to compile php7 ? With ppa or other

[giggsey]

I installed it using a ppa, but that's irrelevant to this library?

[joacub]

In ubuntu 15.10 is possibol pecl is corrupt or bad compile i dont now the problem but tente problem exist

[joacub]

this is system message kernel: [ 1808.603216] php-fpm7.0[1920]: segfault at 10 ip 00007fa07b10d2b7 sp 00007ffeddc7e690 error 4

[joacub]

the problem is library pcre, the version 8.35 in ubuntu 15.10 not run correctly, i have compile manual new version 8.37 and now perfectly regex

[giggsey]

I just tried running the unit tests on a local vagrant box (using hhvm version 3.10.1), and the tests passed fine.

Travis seems to be running hhvm version 3.6.6. So maybe this has actually been fixed in a recent travis version.

[giggsey]

Travis tests now use the latest HHVM version, so closing this issue.