add array type hint to PhoneNumber::__unserialize
#637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ran the tests locally, seems to work fine on php 8.3.7. Should I run them on other versions ? |
IcarusSosie
changed the title
PhoneNumber::__unserialize
|
So apparently this works in PHP 5.3. I had completely forgotten you could use type hints back then. I'll review closer within a few days, but will likely merge. Thanks |
|
Oh, just saw your comment on the PR. That's awesome, thanks ! |
|
Thanks for the fix. The next version will be released once Google release their next version (to maintain version number compatibility). That'll likely be within two weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #636