Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to insatiate profiler using xcactivitylog path #11

Merged
merged 3 commits into from
Nov 14, 2021

Conversation

aChase55
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 97.222% when pulling 6397d9b on aChase55:master into a40f954 on giginet:master.

@pschneider
Copy link

@giginet Hey! Is this something feasible to add? We use a custom build directory (within the repo path ./build/) and xcprofiler seems to not work without passing a custom path for the activity log:

bundle exec xcprofiler --derived-data-path build/Logs/Build/*.xcactivitylog

@giginet
Copy link
Owner

giginet commented Oct 18, 2021

Sorry. I missed this PR for over 1 year... 🙇

I'll check this tomorrow. Sorry for your patience.

Copy link
Owner

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep you waiting such a long time.

I'll fix CI and release this ASAP.

Thank you!

@giginet giginet merged commit 16a6b5c into giginet:master Nov 14, 2021
@giginet
Copy link
Owner

giginet commented Nov 14, 2021

@aChase55 @pschneider Sorry for such a long time 🙏
I just released 0.5.0

@aChase55
Copy link
Contributor Author

Its okay! I forgot I had opened it! Thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants