Allow custom derived data path and ignored_files support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingOfBrian
changed the title
|
Thanks! I'll check this tomorrow |
giginet
approved these changes
Mar 9, 2019
|
@KingOfBrian I just released v0.4.0. Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm setting up danger-xcprofiler on a Jenkins box, and we put the derived data in a different directory. The plugin doesn't allow you to specify a DerivedData directory, but xcprofiler does. This just relays through another string.
Additionally, we have a handful of errors in our Pods directory that I want to be able to ignore. So I added an
ignored_filesproperty to the plugin that mimics the behavior ofdanger-xcode_summaryand allows a simple regular expression.