Add output-json option #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timakin
reviewed
Aug 12, 2017
lib/xcprofiler.rb
Outdated
| @@ -28,6 +28,7 @@ def execute(args) | |||
| opts.on("--derived-data-path", String, "Root path of DerivedData") { |v| options.derived_data_path = v } | |||
| opts.on("-t", "--truncate-at [TRUNCATE_AT]", Integer, "Truncate the method name with specified length") { |v| options.truncate_at = v } | |||
| opts.on("--[no-]unique", "Reject duplicated location results or not") { |v| options.unique = v } | |||
| opts.on("--output-path [PATH]", String, "File path to output reporters' result") { |v| options.output_path = v } | |||
There was a problem hiding this comment.
Should be -o and --output.
At least -path is needless.
There was a problem hiding this comment.
-o is already used. So I renamed to --output
lib/xcprofiler.rb
Outdated
| if options[:output_path] | ||
| json_args = options.dup | ||
| json_args[:output_path] = options[:output_path] | ||
| reporters << JSONReporter.new(json_args) |
There was a problem hiding this comment.
No other style? Only JSON?
|
Is there no test? Maybe you could add the test that generates temporary output JSON and has a validation of regex-match. |
|
There are no tests parsing options. I'm going to add them later. |
|
@timakin I fixed. |
|
LGTM |
timakin
approved these changes
Aug 30, 2017
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20
Add command line option
--output-path. You can specify the path indicates output path forJSONReporter.$ xcprofiler --output-path "result.json" MyApp