Fix #451 #453
Merged
Fix #451 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace setup.cfg and setup.py with pyproject.toml
- Rework workflows:
- remove "repack wheel scripts"
- add docker container actions
- replace cibuildwheel actions with docker container actions +
auditwheel
- replace bdist_wheel with `build`
- build manylinux-compatible wheels
- move pycodestyle config to pycodestyle.yml(pycodestyle don't support pyproject.toml)
gijzelaerr
reviewed
Aug 4, 2023
| @@ -19,4 +19,4 @@ jobs: | |||
| sudo python3 -m pip install --upgrade pip | |||
| sudo python3 -m pip install pycodestyle | |||
| - name: Run pycodestyle | |||
| run: pycodestyle snap7 tests | |||
| run: pycodestyle snap7 tests --ignore=E501,E402,W391,W292,W503 | |||
There was a problem hiding this comment.
shouldn't this be in the pycodestyle config?
There was a problem hiding this comment.
It should. But do we really need to add another config file? Instead, how about keeping this parameter as a command-line option for now and then replacing pycodestyle with ruff that supports pyproject.toml? It will make project's configs more centralized. Ideally, transfer all configurations to pyproject.toml. These parameters too.
There was a problem hiding this comment.
whatever you prefer, i thought might have forgotten it. migrating to ruff is also fine with me.
There was a problem hiding this comment.
I'll take care of migrating to ruff in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build