Stop test after first assertion failure, and handle exceptions thrown…

… from callbacks
gilad61 · Aug 1, 2012 · 3a5e22e · 3a5e22e
1 parent 95b0e8b
commit 3a5e22e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lib/core.js b/lib/core.js
@@ -65,6 +65,12 @@ exports.runTest = function (name, fn, opt, callback) {
     var start = new Date().getTime();
     var test = types.test(name, start, options, callback);
 
+    // Fail the test gracefully if an exception was thrown from a callback
+    process.removeAllListeners('uncaughtException');
+    process.on('uncaughtException', function (exception) {
+      test.done(exception);
+    });
+
     try {
         fn(test);
     }

diff --git a/lib/types.js b/lib/types.js
@@ -79,12 +79,7 @@ var assertWrapper = function (callback) {
         return function () {
             var message = arguments[arity - 1];
             var a = exports.assertion({method: new_method, message: message});
-            try {
-                assert[assert_method].apply(null, arguments);
-            }
-            catch (e) {
-                a.error = e;
-            }
+            assert[assert_method].apply(null, arguments);
             callback(a);
         };
     };