Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black on black text #142

Closed
bonjourjoel opened this issue Apr 1, 2022 · 6 comments
Closed

black on black text #142

bonjourjoel opened this issue Apr 1, 2022 · 6 comments

Comments

@bonjourjoel
Copy link

Hi there,

Since a recent update, i have some text written black on black background in vscode. I believe some update was made to the "TSFILE:..." output's color. And it's not rendering well in vscode's default dark theme for example.
bug-color-terminal

I have used the flag --noColor as a workaround... Maybe you could fix/reverse this?

Regards.

@gilamran
Copy link
Owner

gilamran commented Apr 2, 2022

@pp0rtal Looks like the coloring of the emitted files conflicts with vscode default dark theme... I want to revert the coloring of the file. any objection?

@pp0rtal
Copy link
Contributor

pp0rtal commented Apr 2, 2022

@gilamran No objections, go ahead 👍

By the way and speaking of this, the feature works very well and I'm now able to post-process emitted files.
However, my console is flooded as sometimes hundred of files are rewritten depending the changes, and scrolling hides errors.
I'd like to introduce a specific --hideListedEmittedFiles to hide those occurrences.
I will open a dedicate ticket / PR for this to validate.

Screenshot from 2022-03-29 10-37-26

@gilamran
Copy link
Owner

gilamran commented Apr 2, 2022

It's kinda conflicts with --listEmittedFiles, maybe have a new flag --signalEmittedFiles

@pp0rtal
Copy link
Contributor

pp0rtal commented Apr 2, 2022

@gilamran I'd be happy to take this update if you validate:

  • --listEmittedFiles would pass this param to tsc and don't color it (and make file_emitted event work)
  • --signalEmittedFiles would call tsc with --listEmittedFiles but fully hide TSFILE: lines (= modify tsc output)

Will do it on monday, I should base it on your v5 branch, right?
Or would you like to match v4 and add it to v5?

@gilamran
Copy link
Owner

gilamran commented Apr 3, 2022

@bonjourjoel Fixed on version 5.0.2

@gilamran gilamran closed this as completed Apr 3, 2022
@bonjourjoel
Copy link
Author

Great job, thanks!

pp0rtal added a commit to pp0rtal/tsc-watch that referenced this issue Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants