Change kill signal and add unit test #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilamran
requested changes
May 19, 2020
lib/killer.js
Outdated
| @@ -2,7 +2,7 @@ const psTree = require('ps-tree'); | |||
| const spawn = require('cross-spawn'); | |||
| const { exec } = require('child_process'); | |||
|
|
|||
| let KILL_SIGNAL = '15'; // SIGTERM | |||
| let KILL_SIGNAL = '-15'; // SIGTERM | |||
lib/killer.js
Outdated
| @@ -21,10 +21,10 @@ module.exports = function kill(child) { | |||
| } else { | |||
| if (hasPS) { | |||
| psTree(child.pid, function(err, kids) { | |||
| spawn('kill', ['-s', KILL_SIGNAL, child.pid].concat( kids.map(p => p.PID) )).on('close', resolve); | |||
| spawn('kill', [KILL_SIGNAL, child.pid].concat( kids.map(p => p.PID) )).on('close', resolve); | |||
There was a problem hiding this comment.
here you should use '-' + KILL_SIGNAL
lib/killer.js
Outdated
| }); | ||
| } else { | ||
| exec('kill -s ' + KILL_SIGNAL + ' ' + child.pid, resolve); | ||
| exec('kill ' + KILL_SIGNAL + ' ' + child.pid, resolve); |
There was a problem hiding this comment.
Will do, I wasn't sure which way around you wanted it. Will fix up and update the PR.
|
Thanks for the PR! |
|
@gilamran at first I got spooked by the test failing, but then I saw that it was node6. Do you plan on keeping support for node6? |
|
Published version 4.2.7, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my package.json scripts weren't being killed after the update to version 2.4.6. If I read the documentation correctly (https://pubs.opengroup.org/onlinepubs/9699919799/utilities/kill.html) the actual kill command should be
kill -15.This PR contains that update as well as a unit test to hopefully check the positive and negative case.