-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow props to be overriden by steps #170
Comments
LGTM. |
Looking at the code today it will need to change a lot of code for all options to work. Maybe it is better to add just the big ones for now? Thoughts? |
Hm, personally it doesn't bother me to have a flat structure, since I haven't looked at what it would take to override all of them. The ones I mentioned are basically one-line changes. But, it would be nice to (eventually?) generalize the logic so that whenever a prop is needed, we first check the current step, and then the Joyride |
As for documenting the options, I think that's just a matter of organizing the README and explaining it. I can take a shot at it, and if you think it's unclear we can put them in a |
Let's go flat. I need to rewrite the README anyway. |
Speaking of step properties, I have some questions for you, do you use gitter? |
Yeah, sometimes.. But it's almost 4AM here, I'll crash now. 😴 |
Or plain email too.. |
All tour props can be overridden in V2 |
In some cases, its necessary to change the Joyride props only for particular steps. For example, in some of my steps, I want to show an overlay, but not in other steps. Rather than changing the
<Joyride showOverlay />
prop, it would be great to specify in the steps array itself:In this case, the value specified in the step would have priority over any props provided to the
Joyride
. Other props which I think would be good to be able to override:locale
holePadding
scrollOffset
scrollToStep
showBackButton
showSkipButton
disableOverlay
And maybe a few others. What do you think about allowing properties like that to be specified on steps to override the global props of the Joyride? I can immediately submit PRs for at least
holePadding
andscrollToStep
.The text was updated successfully, but these errors were encountered: