Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disableScrolling prop in the step not overriding the global value #755

Closed
wants to merge 2 commits into from

Conversation

delewis13
Copy link
Contributor

@delewis13 delewis13 commented Nov 9, 2021

Fix something missed in #736

It would be good if the shouldScroll prop of <Step /> also used this shouldScroll method, but wanted to make minimal changes to get things working

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51b8923:

Sandbox Source
React Configuration

@gilbarbara
Copy link
Owner

hey @delewis13

You are trying to merge my own commit back to master?

@delewis13
Copy link
Contributor Author

LOL 🤣

I have evidently made some mistake here, not exactly sure what's gone on, but am about to head to bed will take a look TMR - sorry 😅

@delewis13
Copy link
Contributor Author

delewis13 commented Nov 9, 2021

Errr I don't know what's gone on, or why you are listed author of 22776b7. I must have done something odd in git, but the PR diff matches up with what I would expect (just fixing the arg input to this.shouldScroll). I can see in my own git log that you are listed as author of that commit, but how on earth that happened shrug

I have my own fork of the repo with a branch called delewis13/gilbarbara-master. I added the fix there, then pulled from upstream [your master], then submitted this PR.

Would you like me to close this and re-open one with the correctly labelled author?

@gilbarbara
Copy link
Owner

Too messy

@gilbarbara gilbarbara closed this Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants