Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 support #802

Closed
wants to merge 1 commit into from
Closed

React 18 support #802

wants to merge 1 commit into from

Conversation

kyh
Copy link

@kyh kyh commented May 13, 2022

No description provided.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54781b9:

Sandbox Source
React Configuration

@mapapuche
Copy link

i need to be support on react 18 too ...

@kamte
Copy link

kamte commented May 19, 2022

@gilbarbara do you have an ETA for this?

@JoaoJesus94
Copy link

JoaoJesus94 commented Jun 3, 2022

@gilbarbara Any news on this?

@SheaBelsky
Copy link

FYI - Looks like this will be solved in #809

@gilbarbara
Copy link
Owner

hey @kyh

Thanks for the PR but it wasn't that simple to support React 18.
The StrictMode changed significantly and I had to update react-floater and this library Portal to handle the mount -> unmount -> mount behavior.

Anyway, this is superseded by #809

@gilbarbara gilbarbara closed this Jun 17, 2022
@kyh kyh deleted the patch-1 branch June 24, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants