CLI support for custom credentials for OneDrive (client_id/client_secret) #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: https://forum.duplicacy.com/t/onedrive-using-own-credentials/6507/9 |
|
Thank you for this work! |
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: https://forum.duplicacy.com/t/cli-release-3-2-0-is-now-available/7952/1 |
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: https://forum.duplicacy.com/t/duplicacy-cli-3-2-2-release/8019/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for custom OneDrive credentials (creating own Enterprise App client_id/client_secret). Token refreshes for custom credentials do not need to ping duplicacy.com for refreshes. Existing support for duplicacy.com tokens is kept intact, there should be no impact on anyone not using custom OD credentials.
Ideally, GUI will support optional client_id/client_secret fields, but it is not necessary, everything can be kept on CLI level. client_id should be stored in preferences under keys (e.g. "odb_client_id"), while client_secret should be stored within keyring (e.g. STORAGENAME_odb_client_secret).