Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent current page button to emit event #166

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Prevent current page button to emit event #166

merged 2 commits into from
Aug 7, 2023

Conversation

lombervid
Copy link
Contributor

Fixes #165

@vercel
Copy link

vercel bot commented Apr 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laravel-vue-pagination ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 7:26am

@what-the-diff
Copy link

what-the-diff bot commented Apr 12, 2023 •
edited

PR Summary

  • Prevents emitting events for current page click
    Added a check to avoid triggering events when the user clicks on the currently active page.

  • Disables buttons for already selected pages
    Made improvements to disable buttons for the active page, preventing any unintended actions from occurring.

@gilbitron gilbitron merged commit 18ee7bf into gilbitron:master Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbitron gilbitron gilbitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking current page button emits pagination-change-page event
2 participants
@lombervid @gilbitron