Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show the score for games that have started. #3

Merged
merged 3 commits into from
Jun 21, 2018

Conversation

polevaultweb
Copy link
Contributor

Resolves #1

Now it looks like

image

main.js Outdated
@@ -62,7 +62,7 @@ function setMenu(data) {
menu.append(new MenuItem({ label: 'Today\'s Matches', enabled: false }));

_.forEach(data, (match) => {
menu.append(new MenuItem({ label: getMatchTitle(match), click() {
menu.append(new MenuItem({ label: getMatchTitleWithScore(match), click() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to do some kind of check here, as match.time is null if the game hasn't started (which is why I use match.datetime for upcoming matches). Really we want to show scores if the match.status != 'future', otherwise use getMatchTitle().

@polevaultweb
Copy link
Contributor Author

@gilbitron back - cleaned it up a bit to be simpler.

@gilbitron gilbitron merged commit 5753af6 into gilbitron:master Jun 21, 2018
@polevaultweb polevaultweb deleted the 1-show-todays-results branch June 21, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants