Always show the score for games that have started. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbitron
reviewed
Jun 21, 2018
main.js
Outdated
| @@ -62,7 +62,7 @@ function setMenu(data) { | |||
| menu.append(new MenuItem({ label: 'Today\'s Matches', enabled: false })); | |||
|
|
|||
| _.forEach(data, (match) => { | |||
| menu.append(new MenuItem({ label: getMatchTitle(match), click() { | |||
| menu.append(new MenuItem({ label: getMatchTitleWithScore(match), click() { | |||
There was a problem hiding this comment.
We would need to do some kind of check here, as match.time is null if the game hasn't started (which is why I use match.datetime for upcoming matches). Really we want to show scores if the match.status != 'future', otherwise use getMatchTitle().
|
@gilbitron back - cleaned it up a bit to be simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
Now it looks like