Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[# macro and doc improvements #166

Merged
merged 14 commits into from
Aug 29, 2022
Merged

[# macro and doc improvements #166

merged 14 commits into from
Aug 29, 2022

Conversation

gilch
Copy link
Owner

@gilch gilch commented Aug 28, 2022

Python slices! This one does an injection, but it should be fairly well contained most of the time and it's just too useful to omit. I avoided using it in the macro definitions, although it certainly would have simplified a number of places. I also added to the macro tutorial explaining how to implement this one.

I also reworked the code theme in the docs for better contrast. The default Monokai comments are a little to faint for how much I'm using them.

spy# and time# now pretty-print. This complicates the macros, but just a bit. Not sure if it's worth it yet.

Lots of other doc improvements.

@gilch
Copy link
Owner Author

gilch commented Aug 28, 2022

Probably the pretty prints. Need to update some tests.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #166 (a29c70a) into master (e77fed1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          689       689           
  Branches       108       108           
=========================================
  Hits           689       689           
Impacted Files Coverage Δ
src/hissp/compiler.py 100.00% <ø> (ø)
src/hissp/reader.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gilch gilch merged commit 3594b75 into master Aug 29, 2022
@gilch gilch deleted the docs-pass2 branch August 29, 2022 06:32
@gilch gilch mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant