-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More doc editing and associated improvements. #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliminate /!\
the "Anaphoric." and "Injection." used in macro docstrings
And add direct cross-references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More to do, but this branch has probably run on long enough.
Lots of cross-references in macros and various other documentation improvements.
Notable non-documentation changes include
()
is now implied for non-tuple arguments, like Clojure. The implementations are not really any longer, despite the extra feature, due to simplifications. This did include some judicious use of injections (which are an implementation detail that don't appear in the expansions).deftype@
with@@#
, a decorator reader macro. Turns out reader macros are easily powerful enough to implement the decorator sugar with a tag and extra, at least for the global def- forms, includingdefine
functions. Methods are a different story, but no worse than before.:*
in(@)
and(#)
forms. This is slightly too strict as e.g.(@ :* :*)
now errors, but that had a reasonable interpretation of[':', '*']
before, but this is more likely to be a mistake than useful behavior, and there are other aliases that work fine (just quote it). Adding an exception for these cases didn't seem worth it.