Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More doc editing and associated improvements. #167

Merged
merged 18 commits into from
Sep 9, 2022
Merged

More doc editing and associated improvements. #167

merged 18 commits into from
Sep 9, 2022

Conversation

gilch
Copy link
Owner

@gilch gilch commented Sep 9, 2022

More to do, but this branch has probably run on long enough.

Lots of cross-references in macros and various other documentation improvements.

Notable non-documentation changes include

  • -> / ->> simplification and enhancement. No longer recursive, so the compiler won't insert as many comments. The wrapping () is now implied for non-tuple arguments, like Clojure. The implementations are not really any longer, despite the extra feature, due to simplifications. This did include some judicious use of injections (which are an implementation detail that don't appear in the expansions).
  • Replace deftype@ with @@#, a decorator reader macro. Turns out reader macros are easily powerful enough to implement the decorator sugar with a tag and extra, at least for the global def- forms, including define functions. Methods are a different story, but no worse than before.
  • Detect trailing :* in (@) and (#) forms. This is slightly too strict as e.g. (@ :* :*) now errors, but that had a reasonable interpretation of [':', '*'] before, but this is more likely to be a mistake than useful behavior, and there are other aliases that work fine (just quote it). Adding an exception for these cases didn't seem worth it.

@gilch gilch merged commit 965ac80 into master Sep 9, 2022
@gilch gilch deleted the docs-pass3 branch September 9, 2022 06:16
@gilch gilch mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant