Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content from Button pop-up is not replicated #105

Closed
boweden opened this issue Nov 30, 2018 · 14 comments
Closed

Content from Button pop-up is not replicated #105

boweden opened this issue Nov 30, 2018 · 14 comments

Comments

@boweden
Copy link

boweden commented Nov 30, 2018

The problem:
Clicking on a button that would normally pop-up to show text results in no action.

To reproduce:
Click on any of the 'Spoiler' buttons on this site -- http://www.sierrahelp.com/Hints/FatesOfTwinionSpoilers.html

Expected behavior:
It should display the content associated with that button (in the above example, the 'spoiler' relevant to that button)

Environment:
Win 7 64-bit, Opera

@gildas-lormeau
Copy link
Owner

To fix your issue, please uncheck the following options:

  • HTML content > remove hidden elements
  • Stylesheets > remove unused styles
  • Other resources > remove scripts

@boweden
Copy link
Author

boweden commented Nov 30, 2018

Thank you! Modifying those options seems to fix the problem.

I suppose my follow-up question now is, in what situations would I need to have those options (either all three or one or two of them) enabled? Is it possible to default to those "optimal" settings depending on the web page layout?

@gildas-lormeau
Copy link
Owner

I don't think choosing the best options automatically is something that is doable. However, your issue makes me think about implementing something like profiles. A profile would be a set of predefined options, there would be default profiles like "Fast save", "Faithful save", "Small page" and you could define your owns too. It would appear in the settings at the top right of the page with a combo box, and would be accessible from the context menu. You could also choose the profile you would like to associate with the default save (e.g. when clicking the button). What do you think about this?

@boweden
Copy link
Author

boweden commented Dec 1, 2018

That sounds wonderful. Especially the part about having a 'custom' option to choose your own settings for a specific web page, as well as having the ability to choose your own default profile. Thank you again.

@gildas-lormeau
Copy link
Owner

Well, I did not really talk about a 'custom' option to choose your own settings for a specific web page... But I note it :p.

@gildas-lormeau
Copy link
Owner

The custom options associated to a URL is implemented in 1.9.7 (cf 'auto-settings rules' in the options page).

@gildas-lormeau
Copy link
Owner

@boweden Does this new feature fulfill your needs?

@boweden
Copy link
Author

boweden commented Dec 22, 2018

Wow, incredible. It goes much beyond than fulfilling my needs. :) The way you implemented is very elegant and intuitive. I honestly didn't expect the auto-save part to be so detailed and thorough. 👍 Thank you.

I suppose the <auto-save + auto-settings> feature together could be useful for sites that update frequently (weather/sports/news/stock exchange).

@gildas-lormeau
Copy link
Owner

Thank you also very much for the feedback. I think the combination of features offers indeed some interesting possibilities :)

@endeavorz
Copy link

endeavorz commented Jan 4, 2019

To fix your issue, please uncheck the following options:

* HTML content > remove hidden elements

* Stylesheets > remove unused styles

* Other resources > remove scripts

I had just installed Firefox recently after having used IE (Internet Explorer) for ages, and always had saved webpages in .mht for its single file benefits, and of course IE by default did pick up things within Spoiler tags.

I was sooo disappointed that Firefox did not, until today upon searching the internet and found a write up at ghacks.net about this SingleFile application, so I installed it, but noticed it did not work (with its installed default settings) for getting within spoilers.. ..that is until, finding your post here explaining how to have your settings to now get Spoiler content too! yeah!

I think I am going to leave these settings set this way as default now, because I think it should just do that automatically anyway, at least I think? it should.
There are so many settings in here it will take me a while to understand them all, but I don't want to really think about it, I just want when I save a webpage as a SingleFile - I want it to save everything, and Without needing internet access to get it either!

Nice Job Gildas Lormeau ! ..with your SingleFile application, really Good Work!

Thank you so much !

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Jan 4, 2019

Hi @endeavorz,

Please don't hesitate to give your feedback because I test less often the extension with these options disabled. I enable "remove scripts" by default because, unfortunately, embedding scripts does not guarantee the page will be readable without internet access. For example, if a script loads dynamically another script, then there is a risk SingleFile won't save the second script.
The default options offer a guarantee the page will be saved properly and viewable without any internet access. They're also chosen to produce the smallest possible file.

@endeavorz
Copy link

endeavorz commented Jan 5, 2019

Hello Gildas,

Yes I understand your very good points, thank you.

I have already ran into that situation, where with those 3 unchecked, it saves stuff behind spoilers yes and I can access it offline without internet on those website page saves, but, then on Another website I see it saves fine, but, I can't view the saved file offline or online... ...hmmm, if I send that saved html to IE it opens it, albeit a little messed up.
Okay I just hit your reset button back to default, and now that webpage saves and can view its html when I open it, albeit missing some things.,
But now at default, it won't save another websites spoilers...

And so I see, it's complicated I bet and that's no doubt why you did it the way you did with all these options to cover all scenarios.

I suppose I will have to use the what you said in your post before which is:

The custom options associated to a URL is implemented in 1.9.7 (cf 'auto-settings rules' in the options page)

I have not tried it yet though since I see I only have v1.9.2.....i just checked and made it v1.9.29
hmmm, maybe you did not release 1.9.7 yet?

Anyway I've got nearly everything unchecked on it so I may have to go back and re-checkmark things when I get a chance, to see if I can get it back to work best for all my needs, rather than setting in sites for particular options. Simple is better maybe.

The default options offer a guarantee the page will be saved properly and viewable without any internet access. They're also chosen to produce the smallest possible file.

Understood, nice. However for my own use personally I don't care about the file size of what I save, or compression options - it's more important (to me anyway) to have a 'complete duplicate' and have it display 'without' internet access. Other peoples needs ymmv of course.

Anyway, in the meantime IE save as .mht still works for me most (but not all) times no matter what.
I guess I can leave IE installed and use it at the same time as Firefox..
Going forward I guess since IE is not being supported by more and more websites, I'll leave Firefox set default, and manually open things in IE if I need to save something.
I am still getting use to Firefox as well being so in-tune with IE for so long.

I kept editing my post here as I was testing things, that's why I have so many edits on it, LoL
I'm done now..

Thank you again.. nice stuff, I just need more time to figure out your settings I guess

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Jan 6, 2019

Hi @endeavorz,

You should be able to configure your own auto-settings rules via the options page > auto-settings rules. Note that version 1.9.7 is older than 1.9.29 (i.e. I increment the whole last number when releasing a new version). The idea is to create a profile with the options you want to enable/disable and associate it, through an auto-settings rule, with a domain name (e.g. github.com), or a larger part of the URL (e.g. github.com/gildas-lormeau).

@endeavorz
Copy link

endeavorz commented Jan 6, 2019

1.9.7 is older than 1.9.29?
...whole last number?
...I guess I see what you mean, but would of never caught that and I just use basic numbering where 1.9.7 is greater than 1.9.2. That must be a developer thing to do that I guess.


Okay so I just tried to set up my auto settings and rules with a website that uses spoilers, I put my website link in there, but honestly I can't figure out the GUI logic in what to do, at least to me it's not GUI intuitive to my thinking, and maybe that's my fault.
Also I don't want to have it checkmarked to autosave webpages all the time unless I manually click to save it - but maybe here too, your intent is different than my logical thought.

You have created a nice little extension though and so thank you.

I got frustrated with it and just clicked the RESET button for now, and will use IE to save my webpage.
I think I like IE better than Firefox anyway, but again I guess I have no choice going forward :(

PS,
One thing I noticed with SingleFile set default, that I can save an email page (if I wanted to) in my yahoo account with your app, that's nice, because I could never do that with IE .mht and instead had to take a screenshot, which was fine.
So you see there is advantage with your SingleFile app to be gained, I just need to understand how to use it better i guess in those areas mentioned.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants