-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content from Button pop-up is not replicated #105
Comments
To fix your issue, please uncheck the following options:
|
Thank you! Modifying those options seems to fix the problem. I suppose my follow-up question now is, in what situations would I need to have those options (either all three or one or two of them) enabled? Is it possible to default to those "optimal" settings depending on the web page layout? |
I don't think choosing the best options automatically is something that is doable. However, your issue makes me think about implementing something like profiles. A profile would be a set of predefined options, there would be default profiles like "Fast save", "Faithful save", "Small page" and you could define your owns too. It would appear in the settings at the top right of the page with a combo box, and would be accessible from the context menu. You could also choose the profile you would like to associate with the default save (e.g. when clicking the button). What do you think about this? |
That sounds wonderful. Especially the part about having a 'custom' option to choose your own settings for a specific web page, as well as having the ability to choose your own default profile. Thank you again. |
Well, I did not really talk about a 'custom' option to choose your own settings for a specific web page... But I note it :p. |
The custom options associated to a URL is implemented in 1.9.7 (cf 'auto-settings rules' in the options page). |
@boweden Does this new feature fulfill your needs? |
Wow, incredible. It goes much beyond than fulfilling my needs. :) The way you implemented is very elegant and intuitive. I honestly didn't expect the auto-save part to be so detailed and thorough. 👍 Thank you. I suppose the <auto-save + auto-settings> feature together could be useful for sites that update frequently (weather/sports/news/stock exchange). |
Thank you also very much for the feedback. I think the combination of features offers indeed some interesting possibilities :) |
I had just installed Firefox recently after having used IE (Internet Explorer) for ages, and always had saved webpages in .mht for its single file benefits, and of course IE by default did pick up things within Spoiler tags. I was sooo disappointed that Firefox did not, until today upon searching the internet and found a write up at ghacks.net about this SingleFile application, so I installed it, but noticed it did not work (with its installed default settings) for getting within spoilers.. ..that is until, finding your post here explaining how to have your settings to now get Spoiler content too! yeah! I think I am going to leave these settings set this way as default now, because I think it should just do that automatically anyway, at least I think? it should. Nice Job Gildas Lormeau ! ..with your SingleFile application, really Good Work! Thank you so much ! |
Hi @endeavorz, Please don't hesitate to give your feedback because I test less often the extension with these options disabled. I enable "remove scripts" by default because, unfortunately, embedding scripts does not guarantee the page will be readable without internet access. For example, if a script loads dynamically another script, then there is a risk SingleFile won't save the second script. |
Hello Gildas, Yes I understand your very good points, thank you. I have already ran into that situation, where with those 3 unchecked, it saves stuff behind spoilers yes and I can access it offline without internet on those website page saves, but, then on Another website I see it saves fine, but, I can't view the saved file offline or online... ...hmmm, if I send that saved html to IE it opens it, albeit a little messed up. And so I see, it's complicated I bet and that's no doubt why you did it the way you did with all these options to cover all scenarios. I suppose I will have to use the what you said in your post before which is:
I have not tried it yet though since I see I only have v1.9.2.....i just checked and made it v1.9.29 Anyway I've got nearly everything unchecked on it so I may have to go back and re-checkmark things when I get a chance, to see if I can get it back to work best for all my needs, rather than setting in sites for particular options. Simple is better maybe.
Understood, nice. However for my own use personally I don't care about the file size of what I save, or compression options - it's more important (to me anyway) to have a 'complete duplicate' and have it display 'without' internet access. Other peoples needs ymmv of course. Anyway, in the meantime IE save as .mht still works for me most (but not all) times no matter what. I kept editing my post here as I was testing things, that's why I have so many edits on it, LoL Thank you again.. nice stuff, I just need more time to figure out your settings I guess |
Hi @endeavorz, You should be able to configure your own auto-settings rules via the options page > auto-settings rules. Note that version 1.9.7 is older than 1.9.29 (i.e. I increment the whole last number when releasing a new version). The idea is to create a profile with the options you want to enable/disable and associate it, through an auto-settings rule, with a domain name (e.g. github.com), or a larger part of the URL (e.g. github.com/gildas-lormeau). |
1.9.7 is older than 1.9.29? Okay so I just tried to set up my auto settings and rules with a website that uses spoilers, I put my website link in there, but honestly I can't figure out the GUI logic in what to do, at least to me it's not GUI intuitive to my thinking, and maybe that's my fault. You have created a nice little extension though and so thank you. I got frustrated with it and just clicked the RESET button for now, and will use IE to save my webpage. PS, Thank you |
The problem:
Clicking on a button that would normally pop-up to show text results in no action.
To reproduce:
Click on any of the 'Spoiler' buttons on this site -- http://www.sierrahelp.com/Hints/FatesOfTwinionSpoilers.html
Expected behavior:
It should display the content associated with that button (in the above example, the 'spoiler' relevant to that button)
Environment:
Win 7 64-bit, Opera
The text was updated successfully, but these errors were encountered: