Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly fork that supports saving webpages as unzipped directories #119

Open
pellaeon opened this issue Jan 8, 2022 · 1 comment
Open

Comments

@pellaeon
Copy link

pellaeon commented Jan 8, 2022

Hello,

I developed a fork of SingleFileZ in https://github.com/pellaeon/SingleFileZ , my fork adds a CLI script cli/multifile to save webpages as unzipped directories, same as the request in #102 .

As people have mentioned in #102 , the browser's "Save page as" option doesn't always produce the best results, but SingleFileZ does. Also, as far as I know, it is not possible to use the DevTools protocol to operate the "Save page as" feature, so it is not possible for automatic archiving tools like Archivebox to run "Save page as". SingleFileZ solves the problem.

I understand that providing no zip option might be out of scope for this project, and I respect your decision. However, my multifile tool only slightly differs from the original code, and there are some people using SingleFileZ who needs the feature. So maybe it is still worth incorporating my changes in your repository, please reconsider. I only added 3 source files, without changing existing ones, so it does not affect the existing feature at all or your development.

If you think it could be incorporated, I will tidy up the code and send in a pull request. If not, I'll just keep maintaining my fork.

For a bit more background, I intend to use multifile to add a new extractor in Archivebox. Archivebox already uses the SingleFile CLI tool.

Thank you for this excellent project.

@gildas-lormeau
Copy link
Owner

Thanks a lot, I'll take a look at your implementation to see how I could integrate it into the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants