Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Batch save URL section, It should block user from entering invalid URLs #1345

Closed
GaneshDabhade opened this issue Dec 18, 2023 · 1 comment

Comments

@GaneshDabhade
Copy link

Bug Description:
In the Batch Save URL--> "Add URLs" popup it allows the user to enter invalid URLs.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Batch Save URL and in an empty text box enter any invalid URL (Any string of random characters e.g "github.com/")
  2. Click on the "Add URL" button.
    Behavior: Here it do not allow to enter invalid URL. Which I think is the correct expected behaviour.
  3. Now click on "Add URLs..." button, In the pop up displayed try to add same invalid URL ("github.com/")

Bug:
Here it is not blocking user from adding the invalid URL. Though it is an invalid URL but it still allows user to enter it.

image

Expected behavior
Behavour should be consistent in both the cases i.e "Add URL" and "Add URLs.."
If "Add URL" is not allowing any particular URL to be added then "Add URLs.." should also not allow that URL to be added.

Environment

  • OS: [e.g. Win10 Pro]
  • Browser: [e.g. Chrome, Firefox]
  • Version: [e.g. 64]
@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Dec 19, 2023

Thank you for the detailed report, I changed the input type of the URL from text to url and made the input value required. This will prevent the user from trying to add invalid URLs. The fix will be available in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants