New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exposing close(cb) method #9

Merged

gildean merged 1 commit into gildean:master from hugebdu:close

Sep 4, 2018

Contributor

hugebdu commented Sep 3, 2018

currently the only way to close the proxy server is to use "private" this._server.close, which also doesn't close incoming connections.

couldn't run the tests :(


          exposing close(cb) method

d077854

Owner

gildean commented Sep 4, 2018

Thanks, it looks fine to me and isn't able to break anything. I'll merge and test this.

gildean merged commit 238fc59 into gildean:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment