Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Downloaded 0 Photos. Everything Skipped #32

Closed
saladpanda opened this issue Jan 17, 2019 · 5 comments
Closed

v2: Downloaded 0 Photos. Everything Skipped #32

saladpanda opened this issue Jan 17, 2019 · 5 comments
Labels

Comments

@saladpanda
Copy link

Using the newest version (b04a7e8) gphotos-sync won't download any files.

It creates all the albums with symlinks just fine, but the symlinks point to non-existing files.
Sqlite database (table "SyncFiles") lists all my photos correctly but the logfile lists them all as skipped. E.g.:

01-17 10:44:46 gphotos.Photos DEBUG    Skipped 16 photos/2019/01/IMG_20190116_130626.jpg

Any idea how I can help debug this?

@saladpanda
Copy link
Author

Previous commit f95c72c works fine. So the problem lies in commit b04a7e8

@gilesknap
Copy link
Owner

Hi,
A new feature is that the DB records what it has previously downloaded and won't check again unless you use the new option --retry-download.

Does using this option work? Is this a bad choice of default behaviour?

@gilesknap
Copy link
Owner

Hang on, I just tested a brand new folder and it showed your issue. Must be a bug in the 'already downloaded' logic. Investigating ...

gilesknap added a commit that referenced this issue Jan 17, 2019
@gilesknap
Copy link
Owner

Fixed in latest commit.

Sorry about that. The project has CI but my system tests are very thin since the API update, better test coverage is my next task.

@gilesknap gilesknap added the bug label Jan 17, 2019
@saladpanda
Copy link
Author

Hi,
A new feature is that the DB records what it has previously downloaded and won't check again unless you use the new option --retry-download.

Does using this option work? Is this a bad choice of default behaviour?

Sounds reasonable.

The problem was that nothing was downloaded in a brand new folder. This is fixed now. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants