Dockerfile improvements: size, verbosity and style #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Size: add `--no-cache` switch. Not useful on build, Docker's build caching is responsible of caching. * Add some `-v` switches here and there to add verbosity and provide helpful info when troubleshooting. * Move `export` statement to an `ARG` Docker clause, valid for all the build (only in its own `FROM` scope).
gilesknap
requested changes
May 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 89.21% 88.09% -1.13%
==========================================
Files 25 25
Lines 1957 1957
==========================================
- Hits 1746 1724 -22
- Misses 211 233 +22
Continue to review full report at Codecov.
|
|
Merging - thanks for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-cacheswitch. Not useful on build, Docker's build caching is responsible of caching.-vswitches here and there to add verbosity and provide helpful info when troubleshooting.exportstatement to anARGDocker clause, valid for all the build (only in its ownFROMscope).